[
https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376172#comment-16376172
]
ASF GitHub Bot commented on TINKERPOP-1897:
-------------------------------------------
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/802
Add docker images for console and server TINKERPOP-1897
https://issues.apache.org/jira/browse/TINKERPOP-1897
The Docker images are very similar to [those of
@jbmusso](https://github.com/jbmusso/docker-tinkerpop). Especially the
`docker-entrypoint.sh` scripts are basically the same.
### Base image: Alpine Linux
I opted for an OpenJDK base image with Alpine Linux to get the images as
small as possible. The Console image now only has a size of 120 MB, and the
Server image of 155 MB - compared to 466 MB and 469 MB (uncompressed sizes,
hub.docker.com only shows compressed sizes).
### Maven integration
The Maven integration is done with a [plugin from
Spotify](https://github.com/spotify/dockerfile-maven). It works similar to how
we build the GLVs in that the Docker build is disabled by default and can be
enabled either by explicitly selecting the profile `docker-images` or by
creating a `.docker` file in the modules directory. (This also documented in
the developer docs.)
### To Do: More tags
Right now the images will just get the `project.version` as their tag. We
probably want to add `latest` on master for the 3.3.z line and we might want to
add tags like `3.3` to allow users to just select the minor version to use and
then always get the newest image for that release branch. But we have to make
sure that we don't add tags like `3.3.2` to `SNAPSHOT` images.
I'm afraid that my Maven skills are too limited to get those tags without
hard coding them and especially to avoid `SNAPSHOT` images from getting normal
release tags. My only idea so far is to add a dedicated `execution` element for
the plugin that only adds the release tags and that we have to execute
manually. But maybe someone can come up with a more automatic way?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1897
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #802
----
commit eb73ff7f3f61977cf7bc98f83450d1e308c21f7b
Author: Florian Hockmann <fh@...>
Date: 2018-02-25T17:14:03Z
Add docker images for console and server TINKERPOP-1897
----
> Provide Docker images of Gremlin Server and Console
> ---------------------------------------------------
>
> Key: TINKERPOP-1897
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1897
> Project: TinkerPop
> Issue Type: Improvement
> Components: console, server
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Major
>
> TinkerPop should provide Docker images of Gremlin Server and Gremlin Console
> that are deployed together with each release.
> This originated from the mailing list:
> [https://lists.apache.org/thread.html/744ae19afa9b2fd1984c1e11114dddc588e98786d9c21b633aab8bfa@%3Cdev.tinkerpop.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
