[
https://issues.apache.org/jira/browse/TINKERPOP-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395865#comment-16395865
]
ASF GitHub Bot commented on TINKERPOP-1919:
-------------------------------------------
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/816
TINKERPOP-1919 Merge classes P and TraversalPredicate in Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-1919
This removes the `TraversalPredicate` class by including its functionality
into `P`. That made it easier to enable our Gherkin runner to work with
`P.And()` and `P.Or()` and having `P` as the type for step parameters is
probably also easier to understand for users than `TraversalPredicate`.
I added a `CHANGELOG` entry as this is technically a breaking change as it
removes a public class, but I think that it's unlikely that users interacted
directly with `TraversalPredicate` instead of only via `P.Something().And()`.
This affected 4 previously ignored scenarios. Unfortunately, 2 of those are
still ignored because of TINKERPOP-1922.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1919
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #816
----
commit 97c179d29d7440ac31be791dbeb39e41e54d9a22
Author: Florian Hockmann <fh@...>
Date: 2018-03-12T20:16:18Z
TINKERPOP-1919 Merge classes P and TraversalPredicate
There is no good reason to keep those two classes separate anymore and
having P as the type for step parameters is probably easier to
understand for users than TraversalPredicate.
----
> Gherkin runner doesn't work with P.And() and P.Or() in Gremlin.Net
> ------------------------------------------------------------------
>
> Key: TINKERPOP-1919
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1919
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.2.7
> Reporter: Florian Hockmann
> Priority: Major
> Fix For: 3.2.8, 3.3.2
>
>
> Gremlin.Net has split {{P}} into two classes: {{P}} and
> {{TraversalPredicate}}. This is problematic for the Gherkin runner as it
> tries to call methods on {{P}} that are only in {{TraversalPredicate}}.
> We can now either let the Gherkin parser try to call {{P}} methods on both
> classes or we could also just merge those two classes together. I think the
> reason why they are split was simply that the methods in
> {{TraversalPredicate}} are written by hand whereas {{P}} is completely
> generated and I didn't want to write much code inside of Groovy strings that
> were part of the {{pom.xml}} before [~spmallette] introduced templates for
> the GLV generation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
