[
https://issues.apache.org/jira/browse/TINKERPOP-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400678#comment-16400678
]
ASF GitHub Bot commented on TINKERPOP-1920:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/817
TINKERPOP-1920 Fixed P.within/without() handling for collections
https://issues.apache.org/jira/browse/TINKERPOP-1920
Made the logic the same as what we have in Java currently for `P.within()`
and `P.without()` for handling single collection values. I pretty much just
made this work so open to input from C# experts for a nicer handling of `P`,
but for now in terms of fixing the problem:
Builds with `mvn clean install -pl
:gremlin-dotnet,:gremlin-dotnet-source,:gremlin-dotnet-tests
-DskipIntegrationTests=false`
VOTE+1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1920
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #817
----
commit 065194814b2eafdb82cba665309ba890d04d96dc
Author: Stephen Mallette <spmva@...>
Date: 2018-03-15T16:19:48Z
TINKERPOP-1920 Fixed P.within/without() handling for collections
----
> Tests fail because P.Within() arguments are wrapped in an array in Gremlin.Net
> ------------------------------------------------------------------------------
>
> Key: TINKERPOP-1920
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1920
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.2.7
> Reporter: Florian Hockmann
> Priority: Major
> Fix For: 3.2.8, 3.3.2
>
>
> For the scenario {{g_V_hasIdXwithinXemptyXX_count}}, {{P.within([])}} will be
> serialized as:
> {code}
> {
> "@type": "g:P",
> "@value": {
> "predicate": "within",
> "value": [
> []
> ]
> }
> }
> {code}
> which fails on the server side as it tries to treat {{[]}} as an id:
> {{Expected an id that is convertible to Integer but received class
> java.util.ArrayList}}.
> This seems to be related to the changes made in
> [TINKERPOP-1874|https://issues.apache.org/jira/browse/TINKERPOP-1874].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
