[ https://issues.apache.org/jira/browse/TINKERPOP-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404834#comment-16404834 ]
ASF GitHub Bot commented on TINKERPOP-1920: ------------------------------------------- Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/817#discussion_r175440928 --- Diff: gremlin-dotnet/glv/P.template --- @@ -94,8 +94,8 @@ namespace Gremlin.Net.Process.Traversal <% } %><% pmethods.findAll{ it in ["within", "without"] }.each { method -> %> public static P <%= toCSharpMethodName.call(method) %>(params object[] args) { - if (args.Length == 1 && args[0] is ICollection<object>) - return new P("<%= method %>", ToGenericArray((ICollection<object>) args[0])); + if (args.Length == 1 && args[0] is ICollection<object> collection) + return new P("without", ToGenericArray(collection)); --- End diff -- hahaha....oops - copy/paste. thanks-that was dumb on my part > Tests fail because P.Within() arguments are wrapped in an array in Gremlin.Net > ------------------------------------------------------------------------------ > > Key: TINKERPOP-1920 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1920 > Project: TinkerPop > Issue Type: Bug > Components: dotnet > Affects Versions: 3.2.7 > Reporter: Florian Hockmann > Priority: Major > Fix For: 3.2.8, 3.3.2 > > > For the scenario {{g_V_hasIdXwithinXemptyXX_count}}, {{P.within([])}} will be > serialized as: > {code} > { > "@type": "g:P", > "@value": { > "predicate": "within", > "value": [ > [] > ] > } > } > {code} > which fails on the server side as it tries to treat {{[]}} as an id: > {{Expected an id that is convertible to Integer but received class > java.util.ArrayList}}. > This seems to be related to the changes made in > [TINKERPOP-1874|https://issues.apache.org/jira/browse/TINKERPOP-1874]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)