pluradj On Thu, Apr 5, 2018 at 4:07 PM Stephen Mallette <spmalle...@gmail.com> wrote:
> what's you're nuget account name? > > On Thu, Apr 5, 2018 at 6:53 PM, Jason Plurad <plur...@gmail.com> wrote: > > > I created a nuget account also. I believe I'm already associated with the > > TinkerPop on npm. > > > > On Thu, Apr 5, 2018 at 3:52 PM, Jason Plurad <plur...@gmail.com> wrote: > > > > > Validated the binaries, did several manual tests with the Gremlin > Server > > + > > > Gremlin Console, looked over the documentation. > > > > > > VOTE: +1 > > > > > > On Wed, Apr 4, 2018 at 9:22 AM, Ted Wilmes <twil...@gmail.com> wrote: > > > > > >> Thanks for catching that Jorge. I'm okay with the hack. I'll setup an > > >> npms.js and nuget account. > > >> > > >> --Ted > > >> > > >> On Wed, Apr 4, 2018 at 7:29 AM, Stephen Mallette < > spmalle...@gmail.com> > > >> wrote: > > >> > > >> > If everyone else is ok with the little hack job to get this first > > >> > deployment out, I think I am. > > >> > > > >> > > > >> > On Wed, Apr 4, 2018 at 7:55 AM, Jorge Bay Gondra < > > >> jorgebaygon...@gmail.com > > >> > > > > >> > wrote: > > >> > > > >> > > Whatever you feel more comfortable, as the only risk is publishing > > it > > >> > under > > >> > > the name gremlin-javascript which is going to be deprecated > anyways. > > >> > > > > >> > > If you are going to manually execute "npm publish" in your > terminal, > > >> you > > >> > > have to only change the package name in package.json. > > >> > > If you are planning to use maven with the nodejs plugin to deploy, > > you > > >> > have > > >> > > to change the groovy template file"glv/PackageJson.template" in > > order > > >> to > > >> > > change the generated "package.json" file. > > >> > > > > >> > > 2018-04-04 12:31 GMT+02:00 Stephen Mallette <spmalle...@gmail.com > >: > > >> > > > > >> > > > ugh - not to be sloppy but do we need to kill the artifacts > we've > > >> > already > > >> > > > built over that? how bad would it be if we simply remembered to > > make > > >> > that > > >> > > > change at time of deployment? would that cause problems? > > >> > > > > > >> > > > On Wed, Apr 4, 2018 at 5:44 AM, Jorge Bay Gondra < > > >> > > jorgebaygon...@gmail.com > > >> > > > > > > >> > > > wrote: > > >> > > > > > >> > > > > It looks like the JavaScript package still points to > > >> > > > "gremlin-javascript", > > >> > > > > instead of "gremlin" > > >> > > > > > > >> > > > > https://github.com/apache/tinkerpop/blob/3.2.8/gremlin- > > >> > > > > javascript/src/main/javascript/gremlin-javascript/ > > package.json#L2 > > >> > > > > > > >> > > > > We should change that on both 3.2 and 3.3 branches. > > >> > > > > > > >> > > > > Also, if you are planning to do the JavaScript and C# GLV > > >> releases, > > >> > you > > >> > > > > should create an account on npmjs.com (and be part of the > > >> tinkerpop > > >> > > > team) > > >> > > > > and nuget.org (and be given access rights). > > >> > > > > > > >> > > > > Cheers, > > >> > > > > Jorge > > >> > > > > > > >> > > > > 2018-04-03 18:58 GMT+02:00 Stephen Mallette < > > spmalle...@gmail.com > > >> >: > > >> > > > > > > >> > > > > > validate-distributions.sh was clean for me. also gave some > > >> review > > >> > to > > >> > > > the > > >> > > > > > docs and what i looked at seemed good to go: > > >> > > > > > > > >> > > > > > VOTE +1 > > >> > > > > > > > >> > > > > > On Tue, Apr 3, 2018 at 12:05 PM, Daniel Kuppitz > > <m...@gremlin.guru > > >> > > > >> > > > wrote: > > >> > > > > > > > >> > > > > > > Looks good. > > >> > > > > > > > > >> > > > > > > *Validating binary distributions* > > >> > > > > > > > > >> > > > > > > * downloading Apache TinkerPop Gremlin > > >> > > > > > > (apache-tinkerpop-gremlin-console-3.2.8-bin.zip)... OK > > >> > > > > > > * validating signatures and checksums ... > > >> > > > > > > * PGP signature ... OK > > >> > > > > > > * MD5 checksum ... OK > > >> > > > > > > * SHA1 checksum ... OK > > >> > > > > > > * unzipping Apache TinkerPop Gremlin ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's docs ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's binaries ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's legal files ... > > >> > > > > > > * LICENSE ... OK > > >> > > > > > > * NOTICE ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's plugin directory > ... > > >> OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's lib directory ... > OK > > >> > > > > > > * testing script evaluation ... OK > > >> > > > > > > > > >> > > > > > > * downloading Apache TinkerPop Gremlin > > >> > > > > > > (apache-tinkerpop-gremlin-server-3.2.8-bin.zip)... OK > > >> > > > > > > * validating signatures and checksums ... > > >> > > > > > > * PGP signature ... OK > > >> > > > > > > * MD5 checksum ... OK > > >> > > > > > > * SHA1 checksum ... OK > > >> > > > > > > * unzipping Apache TinkerPop Gremlin ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's docs ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's binaries ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's legal files ... > > >> > > > > > > * LICENSE ... OK > > >> > > > > > > * NOTICE ... OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's plugin directory > ... > > >> OK > > >> > > > > > > * validating Apache TinkerPop Gremlin's lib directory ... > OK > > >> > > > > > > > > >> > > > > > > Validating source distribution > > >> > > > > > > > > >> > > > > > > * downloading Apache TinkerPop 3.2.8 > > >> (apache-tinkerpop-3.2.8-src. > > >> > > > > zip)... > > >> > > > > > > OK > > >> > > > > > > * validating signatures and checksums ... > > >> > > > > > > * PGP signature ... OK > > >> > > > > > > * MD5 checksum ... OK > > >> > > > > > > * SHA1 checksum ... OK > > >> > > > > > > * unzipping Apache TinkerPop 3.2.8 ... OK > > >> > > > > > > * building project ... OK > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > VOTE: +1 > > >> > > > > > > > > >> > > > > > > Cheers, > > >> > > > > > > Daniel > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > On Tue, Apr 3, 2018 at 8:27 AM, Ted Wilmes < > > twil...@gmail.com > > >> > > > >> > > > wrote: > > >> > > > > > > > > >> > > > > > > > Hello, > > >> > > > > > > > > > >> > > > > > > > We are happy to announce that TinkerPop 3.2.8 is ready > for > > >> > > release. > > >> > > > > > > > > > >> > > > > > > > The release artifacts can be found at this location: > > >> > > > > > > > https://dist.apache.org/repos/ > > >> > dist/dev/tinkerpop/3.2.8/ > > >> > > > > > > > > > >> > > > > > > > The source distribution is provided by: > > >> > > > > > > > apache-tinkerpop-3.2.8-src.zip > > >> > > > > > > > > > >> > > > > > > > Two binary distributions are provided for user > > convenience: > > >> > > > > > > > apache-tinkerpop-gremlin-console-3.2.8-bin.zip > > >> > > > > > > > apache-tinkerpop-gremlin-server-3.2.8-bin.zip > > >> > > > > > > > > > >> > > > > > > > The GPG key used to sign the release artifacts is > > available > > >> at: > > >> > > > > > > > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > >> > > > > > > > > > >> > > > > > > > The online docs can be found here: > > >> > > > > > > > http://tinkerpop.apache.org/docs/3.2.8/ (user > > docs) > > >> > > > > > > > http://tinkerpop.apache.org/docs/3.2.8/upgrade/ > > >> > (upgrade > > >> > > > > docs) > > >> > > > > > > > > http://tinkerpop.apache.org/javadocs/3.2.8/core/ > > >> (core > > >> > > > > > javadoc) > > >> > > > > > > > > http://tinkerpop.apache.org/javadocs/3.2.8/full/ > > >> (full > > >> > > > > > javadoc) > > >> > > > > > > > > > >> > > > > > > > The tag in Apache Git can be found here: > > >> > > > > > > > > > >> > > > > > > > https://git-wip-us.apache.org/ > > repos/asf?p=tinkerpop.git;a= > > >> > tag;h= > > >> > > > > > > > f76fd68f83b2479e74c00949549a41173d46b71b > > >> > > > > > > > > > >> > > > > > > > The release notes are available here: > > >> > > > > > > > > > >> > > > > > > > https://github.com/apache/tinkerpop/blob/tp32/CHANGELOG > . > > >> > > > > > > > asciidoc#tinkerpop-328-release-date-april-2-2018 > > >> > > > > > > > > > >> > > > > > > > The [VOTE] will be open for the next 72 hours --- > closing > > >> > Friday > > >> > > > > April > > >> > > > > > > > 6, 2018 at 11:00 AM CDT. > > >> > > > > > > > > > >> > > > > > > > My vote is +1. > > >> > > > > > > > > > >> > > > > > > > Thank you very much, > > >> > > > > > > > Ted Wilmes > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > > > > > > >
