[
https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437364#comment-16437364
]
ASF GitHub Bot commented on TINKERPOP-1822:
-------------------------------------------
Github user krlohnes commented on the issue:
https://github.com/apache/tinkerpop/pull/838
I figured out the errors that I was getting with serialization. I think I
just missed registering `SearchAlgo` in a spots. I have some legitimate test
failures now I think, which makes fixing things quite a bit easier, I can take
a swing at those over the weekend. @mpollmeier
I do like the test you're suggesting, I was trying to come up with a test
case for an existing dataset in the test infrastructure to make sure things
worked there for now. I think testing on a k-ary tree might be worth while too.
A lot of bugs I found when I was testing the general idea were found in that
case.
As far as making DFS the default, my only concern would be breaking
existing traversals. I don't know if there are traversals out there that depend
on `repeat` being BFS that would need to be fixed with a change for the
default. I'd think there would be a desire to not change that behavior default
until the next minor version bump. I'd want to give users a bit of time to know
this exists, and make the switch after there's some awareness of the option to
toggle between the two.
> Repeat should depth first search
> --------------------------------
>
> Key: TINKERPOP-1822
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1822
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Robert Dale
> Priority: Major
>
> Perhaps optionally.
> See also:
> * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE
> * https://github.com/apache/tinkerpop/pull/715
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
