[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451871#comment-16451871
]
ASF GitHub Bot commented on TINKERPOP-1945:
-------------------------------------------
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/842#discussion_r183969723
--- Diff:
gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs
---
@@ -320,6 +323,175 @@ public void ShouldDeserializeTraverser()
Assert.NotNull(d);
Assert.Equal("g:Traverser", (string)d["@type"]);
}
+
+ [Fact]
+ public void ShouldDeserializeDurationToTimeSpan()
+ {
+ var serializedValue =
"{\"@type\":\"gx:Duration\",\"@value\":\"PT120H\"}";
+ var reader = CreateStandardGraphSONReader();
+
+ var jObject = JObject.Parse(serializedValue);
+ TimeSpan deserializedValue = reader.ToObject(jObject);
+
+ Assert.Equal(TimeSpan.FromDays(5), deserializedValue);
+ }
+
+ [Fact]
+ public void ShouldDeserializeBigInteger()
+ {
+ var serializedValue =
"{\"@type\":\"gx:BigInteger\",\"@value\":123456789}";
+ var reader = CreateStandardGraphSONReader();
+
+ var jObject = JObject.Parse(serializedValue);
+ BigInteger deserializedValue = reader.ToObject(jObject);
+
+ Assert.Equal(BigInteger.Parse("123456789"), deserializedValue);
+ }
+
+ [Fact]
+ public void ShouldDeserializeBigIntegerValueAsString()
+ {
+ var serializedValue =
"{\"@type\":\"gx:BigInteger\",\"@value\":\"123456789\"}";
+ var reader = CreateStandardGraphSONReader();
+
+ var jObject = JObject.Parse(serializedValue);
+ BigInteger deserializedValue = reader.ToObject(jObject);
+
+ Assert.Equal(BigInteger.Parse("123456789"), deserializedValue);
+ }
+
+ [Fact]
+ public void CannotDeserializeTooBigIntegerWithOldNewtonsoftJson()
--- End diff --
When a newer version of Newtonsoft.Json can deserialize this, then I'd say
go ahead and update that dependency.
> Add support for extended GraphSon types to Gremlin.net
> ------------------------------------------------------
>
> Key: TINKERPOP-1945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1945
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Reporter: Daniel C. Weber
> Priority: Minor
>
> While Gremlin.net can properly serialize and deserialize all of the core
> GraphSon types, support for most of the extended types as described
> [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
