Thanks for taking 3.2.9 Robert. 3.3.3 is still up for grabs if anyone else wants to take that one.....
We still need to merge these three PRs: https://github.com/apache/tinkerpop/pull/854 - needs a VOTE still before merge https://github.com/apache/tinkerpop/pull/858 and https://github.com/apache/tinkerpop/pull/852 - Jorge is off this week, but I assume he will merge early next week I don't think we need to worry about any others. Jorge and maybe Jean-Baptiste, I've noticed more than a few people having issues with gremlin-javascript - the two things of concern: 1. documentation 2. how to send scripts I seem to sense that a lot of the confusion that led to item 1 is addressed in TINKERPOP-1944 as well as the issue that CosmosDB doesn't support bytecode which then leads to item 2 because you need to send scripts there. On top of all that we also didn't get things clear as to what happened in the npm gremlin repository when we basically deprecated out the "unofficial" gremlin-javascript that JB maintained, flubbed the documentation on which npm repo to use, etc.. Can either of you speak to how 3.2.9/3.3.3 (and whatever else we might have done) will better address those issues now that we have a second chance at getting this all "right"? I want the groovy issue fixed, but I'd like to polish up gremlin-javascript more as well and if we need extra time to do that, I think we should take that time and not rush to release. Thanks! On Thu, Apr 26, 2018 at 8:18 AM, Robert Dale <robd...@gmail.com> wrote: > I'll take 3.2.9 > > Robert Dale > > On Thu, Apr 26, 2018 at 7:35 AM, Stephen Mallette <spmalle...@gmail.com> > wrote: > > > Seems like we're all on board with getting a quick turnaround release out > > the door. At this point the groovy fix is now in place and Jorge has both > > TINKERPOP-1943/1944 prepared. Unless there are other major issues anyone > > wants to bring up, we should consider a code freeze starting this friday > > and plan for a release the week of May 7. > > > > Any volunteers to help with release management duties? > > > > > > > > On Mon, Apr 23, 2018 at 9:19 AM, Jorge Bay Gondra < > > jorgebaygon...@gmail.com> > > wrote: > > > > > sgtm, I'm also +1 on releasing patch releases asap to fix it. > > > > > > Regarding gremlin-javascript, we could include TINKERPOP-1944 (I just > > > submitted a pull request) but I'm not sure we can include > TINKERPOP-1943, > > > the implementation is trivial but it will require some changes to make > > the > > > test suite pass with GraphSON3 (Map instances vs Objects). > > > > > > > > > 2018-04-23 15:00 GMT+02:00 Robert Dale <robd...@gmail.com>: > > > > > > > +1 > > > > > > > > Robert Dale > > > > > > > > On Mon, Apr 23, 2018 at 8:44 AM, Stephen Mallette < > > spmalle...@gmail.com> > > > > wrote: > > > > > > > > > Based on: > > > > > > > > > > https://lists.apache.org/thread.html/ > de4ec9054fd7a88cbd42163a0b1050 > > > > > 19aae52a7e930b09a9bd4c971d@%3Cdev.tinkerpop.apache.org%3E > > > > > > > > > > We have a pretty serious bug that I can't seem to find a workaround > > > for. > > > > > The only workaround I can think of would be to replace this: > > > > > > > > > > Lambda.function("it.get()") > > > > > > > > > > with > > > > > > > > > > new OneArgLambda("it.get()", "gremlin-groovy") > > > > > > > > > > Not great as existing code using Lambda will break and none of the > > docs > > > > > make any reference to direct usage of the various "Lambda" > > > constructors. > > > > > So, short of someone suggesting one very quickly, I think we need > to > > > > > release a patch. > > > > > > > > > > Any concerns with doing that? Also, assuming we proceed with the > > patch > > > as > > > > > quickly as possible, can anyone think of any critical items that > need > > > to > > > > be > > > > > done for 3.2.9/3.3.3? > > > > > > > > > > As a side note, this is somewhat good for gremlin-javascript as we > > > sorta > > > > > flubbed the documentation a bit and missed some > odds/ends.....perhaps > > > > this > > > > > allows us to get that patched up as well sooner than expected? > > > > > > > > > > > > > > >
