[
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477508#comment-16477508
]
ASF GitHub Bot commented on TINKERPOP-1945:
-------------------------------------------
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Good to see that you resolved the problem with the Newtonsoft.Json version.
I think it makes sense to only support GraphSON types for which we find
good equivalents in .NET and leave others out for now, like `g:MonthDay` for
example. When users actually need them, then we can still think about how we
can implement them in .NET.
Regarding your latest commits where you merged serializers and
deserializers together: We usually have serializers and deserializers separated
in different classes. The only exception I see is the `NumberConverter` with
its child classes which we put together in just one base class so we don't have
to create two subclasses for every numerical datatype.
I think we should stick with separated serializers and deserializers, not
because I like it better that way, but because other TinkerPop GLVs also do it
like that and we try to stay consistent across GLVs.
Apart from that, the PR is good to go from my side.
> Add support for extended GraphSon types to Gremlin.net
> ------------------------------------------------------
>
> Key: TINKERPOP-1945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1945
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Reporter: Daniel C. Weber
> Priority: Minor
>
> While Gremlin.net can properly serialize and deserialize all of the core
> GraphSon types, support for most of the extended types as described
> [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
