[
https://issues.apache.org/jira/browse/TINKERPOP-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480953#comment-16480953
]
ASF GitHub Bot commented on TINKERPOP-1897:
-------------------------------------------
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/802#discussion_r189340476
--- Diff: gremlin-console/pom.xml ---
@@ -336,5 +336,59 @@ limitations under the License.
</plugins>
</build>
</profile>
+
+ <profile>
+ <id>docker-images</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ <file>
+ <exists>.docker</exists>
+ </file>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.spotify</groupId>
+ <artifactId>dockerfile-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>docker-image-build</id>
+ <goals>
+ <goal>build</goal>
+ </goals>
+ <configuration>
+ <tag>${project.version}</tag>
+ <buildArgs>
+
<GREMLIN_CONSOLE_DIR>target/apache-tinkerpop-${project.artifactId}-${project.version}-standalone</GREMLIN_CONSOLE_DIR>
+ </buildArgs>
+ </configuration>
+ </execution>
+ <execution>
+ <id>docker-image-tag-minor-version</id>
+ <goals>
+ <goal>tag</goal>
+ </goals>
+ <configuration>
+ <tag>3.2</tag>
--- End diff --
Making it dynamic would of course be the best solution and it looks like we
can again use the `build-helper-maven-plugin` for this:
> The parse-version goal can be used to access the component parts of a
version string. For example, the major version or the qualifier by themselves.
Source: http://www.mojohaus.org/build-helper-maven-plugin/usage.html
I will try that out and then either update the PR accordingly or add
something to the dev docs if it doesn't work.
> Provide Docker images of Gremlin Server and Console
> ---------------------------------------------------
>
> Key: TINKERPOP-1897
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1897
> Project: TinkerPop
> Issue Type: Improvement
> Components: console, server
> Affects Versions: 3.2.7
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Major
>
> TinkerPop should provide Docker images of Gremlin Server and Gremlin Console
> that are deployed together with each release.
> This originated from the mailing list:
> [https://lists.apache.org/thread.html/744ae19afa9b2fd1984c1e11114dddc588e98786d9c21b633aab8bfa@%3Cdev.tinkerpop.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
