[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482925#comment-16482925 ]
Marc de Lignie edited comment on TINKERPOP-1967 at 5/21/18 7:15 PM: -------------------------------------------------------------------- I gave your feature branch a quick scan: * your {{ConnectedComponentVertexProgram}} is clearly much more developed with all the traversal steps present * I am not so sure we can simply dismiss the OLTP traversal as educational only after the improvements Robert Dale and I made (see the code in the recipe of my feature branch). I would like to run some performance tests on in-memory TinkerGraphs to be sure. If there is still use for the OLTP query, my take on the recipe would provide useful text (in addition to its external references and the explanation about weakly connected components) * Also for your code it would be worthwhile to run a one-off test with the friendster graph (I plan to do this, but no problem if you chime in on this). * It is a good idea indeed to mention that the vertexprogram will be present since 3.4.0, because users of older versions may yet land on the latest ref docs. was (Author: hadoopmarc): I gave your feature branch a quick scan: * your {{ConnectedComponentVertexProgram}} is clearly much more developed with all the traversal steps present * I am not so sure we can simply dismiss the OLTP traversal as educational only after the improvements Robert Dale and I made (see the code in the recipe of my feature branch). I would like to run some performance tests on in-memory TinkerGraphs to be sure. If there is still use for the OLTP query, my take on the recipe would provide useful text (apart from the external references and the explanation about weakly connected components) * Also for your code it would be worthwhile to run a one-off test with the friendster graph (I plan to do this, but no problem if you chime in on this). * It is a good idea indeed to mention that the vertexprogram will be present since 3.4.0, because users of older versions may yet land on the latest ref docs. > Add a connectedComponent() step > ------------------------------- > > Key: TINKERPOP-1967 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1967 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.3.3 > Reporter: stephen mallette > Assignee: stephen mallette > Priority: Minor > Fix For: 3.4.0 > > > Given TINKERPOP-1852 we should probably just simplify and improve performance > of connected component identification. Implementing this will involved the > creation of {{ConnectedComponentVertexProgram}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)