Github user GCHQResearcher1337 commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/876#discussion_r202418371
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/util/LabelledCounter.java
 ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.tinkerpop.gremlin.process.traversal.traverser.util;
    +
    +import org.apache.commons.lang.mutable.MutableShort;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Class to track a count associated with a Label
    + */
    +public class LabelledCounter implements Serializable, Cloneable {
    +
    +    private final String label;
    +    private final MutableShort count = new MutableShort();
    --- End diff --
    
    Whoops that my mistake. I'll change it to a primitive short. 
    
    It's a short to match the loop counters used elsewhere e.g.
    
https://github.com/GCHQResearcher1337/tinkerpop/blob/a80eb84169048ed74c5ad27ebc4d12944fd0136a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_S_SE_SL_Traverser.java#L34
    
    But I originally used a Pair<> before switching to a class, which prevented 
me from using primitive types.


---

Reply via email to