[
https://issues.apache.org/jira/browse/TINKERPOP-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544638#comment-16544638
]
ASF GitHub Bot commented on TINKERPOP-2007:
-------------------------------------------
GitHub user svanteschubert opened a pull request:
https://github.com/apache/tinkerpop/pull/892
Tinkerpop 2007
For ease of handling, I let the easier fix of
[TINKERPOP-2007](https://issues.apache.org/jira/browse/TINKERPOP-2007) depend
on [TINKERPOP-2006](https://issues.apache.org/jira/browse/TINKERPOP-2006).
We might consider extending the fix to overwrite all Comparators not only
those for GraphML.
I did this once in a test run, but then I would need to exchange also JSON
test files and did not oversee all implications like in the isolation of the
GraphMLWriter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/svanteschubert/tinkerpop TINKERPOP-2007
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #892
----
commit cfc7ecefd370ac438afea03f1e6d718f1eff0fbe
Author: Svante Schubert <svante.schubert@...>
Date: 2018-07-15T18:26:10Z
TINKERPOP-2006 - Fix for valid GraphML export when graph properties of a
vertex and edge have similar name
commit 10292f4ead80796748f3ecc8cba8a8b0412afe14
Author: Svante Schubert <svante.schubert@...>
Date: 2018-07-15T18:33:16Z
TINKERPOP-2007 - GraphML export is normalized by default and better ordered
to ease 3rd party regression testing
----
> GraphML serialization shall by default be ordered and have an improved
> ordering
> -------------------------------------------------------------------------------
>
> Key: TINKERPOP-2007
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2007
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.3.3
> Reporter: Svante Schubert
> Priority: Minor
>
> To ease readability and regression tests based on GraphML files (especially
> used for loading Graphs into Gephi) I suggest to
> a) order (or normalize) the GraphML by default (e.g. from Gremlin console)
> b) improve the ordering if numbers are involved, oppose to String only:
> Currently, in the reference test file for normalized GraphML
> ["tinkerpop-classic-normalized.xml"|https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/structure/io/graphml/tinkerpop-classic-normalized.xml],
> the ordering of edge IDs goes like
> 10
> 11
> 12
> 7
> 8
> 9
> instead of
> 7
> 8
> 9
> 10
> 11
> 12
> It goes even jumpier if hundred or thousand of edges are involved.
>
> I am going to provide a GitHub pull request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
