[
https://issues.apache.org/jira/browse/TINKERPOP-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552052#comment-16552052
]
ASF GitHub Bot commented on TINKERPOP-2012:
-------------------------------------------
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/895
TINKERPOP-2012 Add .NET Standard 2.0 target to Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-2012
This simply adds .NET Standard 2.0 as an additional target for Gremlin.Net.
Since it doesn't really require any additional effort to target multiple
frameworks, it doesn't make much sense to drop the existing .NET Standard 1.3
target. That way, we don't drop support for any .NET implementations or
versions, especially the current .NET Core LTS versions 1.0 and 1.1 as
@jorgebay mentioned in the JIRA issue.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-2012
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/895.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #895
----
commit d309b7a987f821c2536e57d386808976ccb5bde1
Author: Florian Hockmann <fh@...>
Date: 2018-07-22T14:55:15Z
Add .NET Standard 2.0 target TINKERPOP-2012
----
> Target .NET Standard 2.0 for Gremlin.Net
> ----------------------------------------
>
> Key: TINKERPOP-2012
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2012
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.3.3, 3.2.9
> Reporter: Florian Hockmann
> Priority: Major
>
> The general recommendation from the .NET team is now to target .NET Standard
> 2.0 instead of the lowest version possible (which was the recommendation
> until .NET Standard 2.0):
> {quote}I know we said target The lowest netstandard but we really want
> everyone to re-baseline at netstandard 2.0. At the very least add a
> netstandard 2.0 target.
> {quote}
> [Source|https://twitter.com/davidfowl/status/1008453902058917888]
> Apart from an increased API surface compared to .NET Standard 1.x, .NET
> Standard reduces the dependency graph of libraries. Right now the
> dependencies for Gremlin.Net look like this:
> *.NETStandard 1.3*
> * NETStandard.Library (>= 1.6.1)
> * Newtonsoft.Json (>= 9.0.1)
> * System.Net.WebSockets (>= 4.3.0)
> * System.Net.WebSockets.Client (>= 4.3.0)
> * System.Reflection.TypeExtensions (>= 4.3.0)
> With .NET Standard 2.0, the only dependency left should be Newtonsoft.Json.
> We have to decide whether we want to upgrade from .NET Standard 1.3 or to
> just add .NET Standard 2.0 as an additional target framework. Upgrading would
> mean that consuming applications would need slightly newer framework versions
> (e.g. .NET Framework 4.6.1 instead of 4.6 or Mono 5.4 instead of 4.6).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
