[ 
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562054#comment-16562054
 ] 

ASF GitHub Bot commented on TINKERPOP-2006:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/891
  
    @svanteschubert do you plan to come back to this one and #892 ? I think 
that if you address @twilmes issues here we could push forward at least this 
change and get it merged. Also, if you are coming back to this, I think we'd 
want to see some tests for this change somehow. None of the toy graphs have 
shared edge/vertex property keys that I can think of, so you might need special 
test graph data for this.


> GraphML serialization invalid if a vertex and edge have similar named property
> ------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2006
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2006
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 3.3.3
>            Reporter: Svante Schubert
>            Priority: Trivial
>
> I have created a graph using the Tinkerpop Graph and required for Gephi 
> visualization a property called color on edges and vertices to be coloured.
> The current gremlin-core serialization creates the following two key elements 
> in GraphML
> <key id="color" for="node" attr.name="color" attr.type="string"></key>
> <key id="color" for="edge" attr.name="color" attr.type="string"></key>
> the id attribute is an internal name, but have to be different.
> I would suggest a patch to check for an intersection of the edge & vertices 
> keys and add for those keys an additional differentiating letter like:
> <key id="colorV" for="node" attr.name="color" attr.type="string"></key>
> <key id="colorE" for="edge" attr.name="color" attr.type="string"></key>
>  
> Going to provide a pullrequest on GitHub.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to