Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206485044
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected AbstractEvalOpProcessor(final boolean
manageTransactions) {
* script evaluation.
* @param bindingsSupplier A function that returns the {@link
Bindings} to provide to the
* {@link GremlinExecutor#eval} method.
+ * @see #evalOpInternal(ResponseHandlerContext, Supplier,
BindingSupplier)
*/
protected void evalOpInternal(final Context context, final
Supplier<GremlinExecutor> gremlinExecutorSupplier,
--- End diff --
it was good that you kept the old signature as other people might depend on
this. i was thinking we might deprecate, this version of the method, but
perhaps that is not necessary or perhaps even undesired. I guess, the question
is whether or not the new method would ever be called directly or would it
always be called through this method? Perhaps the other method should be
`private`?
---
