Github user svanteschubert commented on the issue:

    https://github.com/apache/tinkerpop/pull/891
  
    1) Yes, "Collection<String> vertexKeySet.." and same for the edge can still 
be made final, good catch.
    
    2) No, I did not make any performance test, do you have one for Tinkerpop, 
what would you suggest? 
    In any case, I leave it to your taste to adopt it to your desire 
{#emotions_dlg.wink}
    
    3) There is a key declared in the header of the for loop, what is your 
suggestion? I do not fully understand your suggestion. Again, I have no strong 
feelings, in case you like to adopt the source. I only want to remove the 
reported problem.
    
    4) The scenario comes from creating a graph with Tinkerpop using same-named 
property on edge and vertex and serializing it to GraphML. A regression test 
might be the extending an existing Graph example with the color property for an 
edge and vertex, which would be the correct location/class to create in 
Tinkerpop such a regression test?



---

Reply via email to