Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/899#discussion_r206570383
--- Diff:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
---
@@ -222,9 +223,33 @@ protected AbstractEvalOpProcessor(final boolean
manageTransactions) {
* script evaluation.
* @param bindingsSupplier A function that returns the {@link
Bindings} to provide to the
* {@link GremlinExecutor#eval} method.
+ * @see #evalOpInternal(ResponseHandlerContext, Supplier,
BindingSupplier)
*/
protected void evalOpInternal(final Context context, final
Supplier<GremlinExecutor> gremlinExecutorSupplier,
--- End diff --
well - i guess, keep it open as `protected` - i guess if someone is writing
one of these they will need to know how all of it works i guess. perhaps this
is where other PRs comes in for tp33 and master. maybe we deprecate in 3.2.x
and then remove them for 3.4.0.
---
