[jira] [Created] (TINKERPOP-2017) Check for Column in by()

[stephen mallette (JIRA)]

stephen mallette created TINKERPOP-2017:
-------------------------------------------

             Summary: Check for Column in by()
                 Key: TINKERPOP-2017
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2017
             Project: TinkerPop
          Issue Type: Improvement
          Components: process
    Affects Versions: 3.2.9
            Reporter: stephen mallette
            Assignee: stephen mallette


The {{by(Function)}} doesn't check for {{Column}}:

https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L57

as it does here:

https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L94

Seems like it would be better to just add:

{code}
if (function instanceof Column)
    this.modulateBy(new ColumnTraversal((Column) function))
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)