[
https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578349#comment-16578349
]
ASF GitHub Bot commented on TINKERPOP-2017:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/908
Cherry picked this commit to tp32 - a0a243b256dbfdf66bb5ce24958fc91c7e6eed03
> Check for Column in by()
> ------------------------
>
> Key: TINKERPOP-2017
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2017
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.9
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
>
> The {{by(Function)}} doesn't check for {{Column}}:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L57
> as it does here:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L94
> Seems like it would be better to just add:
> {code}
> if (function instanceof Column)
> this.modulateBy(new ColumnTraversal((Column) function))
> {code}
> Mentioned here on the user list:
> https://groups.google.com/d/msg/gremlin-users/Y0fez_aLdqs/nyUKQkO_AAAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
