[
https://issues.apache.org/jira/browse/TINKERPOP-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582716#comment-16582716
]
ASF GitHub Bot commented on TINKERPOP-1913:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r210646017
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -51,7 +52,18 @@ public async Task
ShouldSendScriptForEvaluationAndReturnCorrectResult(string req
Assert.Equal(expectedResponse, response);
}
}
-
+
+ [Fact]
+ public async Task ShouldReturnResponseAttributes()
+ {
+ var gremlinServer = new GremlinServer(TestHost, TestPort);
+ using (var gremlinClient = new GremlinClient(gremlinServer))
+ {
+ var requestMsg = _requestMessageProvider.GetDummyMessage();
+ var resultSet = await
gremlinClient.SubmitAsync<object>(requestMsg);
+ Assert.NotNull(resultSet.StatusAttributes);
--- End diff --
Sorry...the last rebase I did broke something. So, I fixed that, rebased
again and added a few other minor changes. If you rebase your work on
TINKERPOP-1913 I think things should start working here again.
> Expose metadata from Gremlin Server to Clients
> ----------------------------------------------
>
> Key: TINKERPOP-1913
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1913
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, driver, javascript, python, server
> Affects Versions: 3.3.1
> Reporter: Ashwini Singh
> Assignee: stephen mallette
> Priority: Major
>
> To summarize what we have discussed so far:
> 1. For API using GremlinRequest/QueryScript, expose response attribute as
> part of result. Using an approach to similar to Java client driver (using
> ResultSet) . [Priority0]
> -- We rely on the last message for response attributes.
> 2. For GLV, add response attribute as part of Traversal. [Priority 0]
> --Rely on the last message for attributes.
> 3. Expose other server details (like server setting). I would suggest to
> split this design discussion into two directions:
> a. Metadata for request execution: Only focuses on details
> related to request execution. Can be achieved through #1 and #2.
> b. Metadata for Gremlin Server: Focuses on overall metadata
> for the server. Could be a separate request and fetch the data once for a
> connection.
> Targeted drivers: dotnet, Java, python, javascript.
> More details:
> [https://lists.apache.org/thread.html/fd2208a2db827bc1eb479ad8c2f181bd2fa532553c97b3fe6994a7b6@%3Cdev.tinkerpop.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
