GitHub user justinchuch opened a pull request:
https://github.com/apache/tinkerpop/pull/918
Update comments in GraphProvider clear() and openTestGraph() [tp33]
What's changed [tp33]:
Classes that have implemented `GraphProvider#clear` must note that the
parameter `graph` and `config` are nullable, so that a proper `null` checking
and handling is needed. Otherwise, test cases that have extended
`org.apache.tinkerpop.gremlin.AbstractGremlinTest.java` may throw exception
when it comes to `tearDown()`
* Update comments in `GraphProvider#clear`, `GraphProvider#openTestGraph`.
* Add `null` checking in the `clear` method of the three implemented
`GraphProvider`:
- `org.apache.tinkerpop.gremlin.neo4j.AbstractNeo4jGraphProvider.java`
- `org.apache.tinkerpop.gremlin.tinkergraph.TinkerGraphProvider.java`
- `org.apache.tinkerpop.gremlin.util.TinkerGraphProvider.java`
* `org.apache.tinkerpop.gremlin.AbstractGremlinTest`
- Set `graph` to `null` when `tearDown()`
- Add comment at `tearDown()`
- Remove unused imports
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinchuch/tinkerpop graphprovider-clear-tp33
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/918.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #918
----
commit 32a8ee6d2faed5bfbb36dd30d17dff7d6cff03e0
Author: Justin Chu <15710241+justinchuch@...>
Date: 2018-08-21T19:13:25Z
Add null checking for configuration
commit 038b9cd759d0ac97a3c3820ec55026938d4c74be
Author: Justin Chu <15710241+justinchuch@...>
Date: 2018-08-21T19:14:16Z
Update javadoc and comments for clear method;
Remove unused import
commit bf94f43f39c7812adec402730aaa2a8ed8526900
Author: Justin Chu <15710241+justinchuch@...>
Date: 2018-08-21T22:24:42Z
Merge branch 'graphprovider-clear-tp32' into graphprovider-clear-tp33
commit 6efd47da55c1d621714c481b21cf8b4494585680
Author: Justin Chu <15710241+justinchuch@...>
Date: 2018-08-21T22:28:59Z
Add null checking for configuration;
Remove unused import
----
---
