[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595505#comment-16595505
]
ASF GitHub Bot commented on TINKERPOP-2028:
-------------------------------------------
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/923
TINKERPOP-2028: Register GremlinServerModule to GraphSON message seri…
…alizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek/incubator-tinkerpop TINKERPOP-2028
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/923.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #923
----
commit 6513ce68c37fbdcb57bfa54f68b739d6e8f176cc
Author: Kevin Gallardo <kevin.gallardo@...>
Date: 2018-08-28T19:34:30Z
TINKERPOP-2028: Register GremlinServerModule to GraphSON message serializer
----
> AbstractGraphSONMessageSerializerV2d0 should register GremlinServerModule
> when mapper is provided
> -------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2028
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2028
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.3.1, 3.2.9
> Reporter: Kevin Gallardo
> Priority: Major
>
> When specifying a {{GraphSONMapper}} when constructing a
> {{GraphSONMessageSerializerV3d0}}, the Message serializer will not register
> any module. Hence users will have to manually register the
> {{GremlinServerModule}} to the GraphSONMapper they are giving in parameter
> for it to work at all:
> {code:java}
> GraphSONMessageSerializerV3d0 messageSerializerV3d0 =
> new GraphSONMessageSerializerV3d0(
> GraphSONMapper.build()
> .version(GraphSONVersion.V3_0)
> .addCustomModule(new
> AbstractGraphSONMessageSerializerV2d0.GremlinServerModule())
> .addRegistry(TinkerIoRegistryV3d0.instance()).create());
> {code}
> When not providing a Mapper, the GremlinServerModule is registered
> automatically. It sounds reasonable in the context of the
> {{GraphSONMessageSerializer}} to automatically register the
> {{GremlinServerModule}} wdyt?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
