[
https://issues.apache.org/jira/browse/TINKERPOP-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-2033:
----------------------------------------
Labels: (was: breaking)
Description:
The {{annotations}} of {{ImmutableMetrics}} uses a {{ConcurrentHashMap}} but
that of course loses the insertion order. Convert to a {{synchronizedMap}} that
takes a {{LinkedHashMap}} to maintain that order as well as the ability to
support concurrent access which is an issue for some graphs.
There was some question as to whether or not this change was breaking to the
Gryo format or not ,but it appears that it is not. Gryo 1.0 and 3.0 remain as
intact as they were on previous releases, though it is worth noting that Gryo
1.0 broke on release on 3.3.0 when it comes to "metrics" serialization so that
break is still intact. Therefore you can't use Gryo 1.0 between 3.2.x and
3.3.x/3.4.x. Not sure how that happened exactly.
was:
The {{annotations}} of {{ImmutableMetrics}} uses a {{ConcurrentHashMap}} but
that of course loses the insertion order. Convert to a {{synchronizedMap}} that
takes a {{LinkedHashMap}} to maintain that order as well as the ability to
support concurrent access which is an issue for some graphs.
This is a breaking change on Gryo 1.0 because there was no abstraction for
"metrics" class serialization in Gryo for that version. Any sort of change to
the object model would cause a break. Upgrade docs will discuss the upgrade
options.
> Maintain order of profile() annotations
> ---------------------------------------
>
> Key: TINKERPOP-2033
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2033
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.4.0
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.4.0
>
>
> The {{annotations}} of {{ImmutableMetrics}} uses a {{ConcurrentHashMap}} but
> that of course loses the insertion order. Convert to a {{synchronizedMap}}
> that takes a {{LinkedHashMap}} to maintain that order as well as the ability
> to support concurrent access which is an issue for some graphs.
> There was some question as to whether or not this change was breaking to the
> Gryo format or not ,but it appears that it is not. Gryo 1.0 and 3.0 remain as
> intact as they were on previous releases, though it is worth noting that Gryo
> 1.0 broke on release on 3.3.0 when it comes to "metrics" serialization so
> that break is still intact. Therefore you can't use Gryo 1.0 between 3.2.x
> and 3.3.x/3.4.x. Not sure how that happened exactly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
