Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/943#discussion_r221908780
  
    --- Diff: 
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Settings.java 
---
    @@ -243,6 +243,8 @@ public static Settings from(final Configuration conf) {
                 if (connectionPoolConf.containsKey("keepAliveInterval"))
                     cpSettings.keepAliveInterval = 
connectionPoolConf.getLong("keepAliveInterval");
     
    +            if (connectionPoolConf.containsKey("validationRequest"))
    +                cpSettings.validationRequest = 
connectionPoolConf.getList("validationRequest").stream().map(Object::toString).collect(Collectors.joining(","));
    --- End diff --
    
    I thought that period as with the script `g.inject()` was being treated as 
a delimiter for Apache Configuration, but I can't get the test to fail anymore, 
so I must have been mistaken in what I was seeing. changing it.


---

Reply via email to