[ https://issues.apache.org/jira/browse/TINKERPOP-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635910#comment-16635910 ]
ASF GitHub Bot commented on TINKERPOP-2053: ------------------------------------------- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/945 TINKERPOP-2053 Support for OptionsStrategy https://issues.apache.org/jira/browse/TINKERPOP-2053 `OptionsStrategy` lets users pass arbitrary configurations at a traversal level. At first I thought this might be a first class object, but decided instead to try it out as a `TraversalStrategy`. In that way it was implemented with little overhead. If it becomes useful and popular in the future then we can consider making it more integrated into the `TraversalSource` and `Traversal` itself. I didn't implement this for javascript because I don't think we have all the infrastructure there for supporting `TraversalStrategy` stuff yet. All tests pass with `docker/build.sh -t -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2053 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/945.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #945 ---- commit 91573d5c7d44944186a9cd11ce880dec32caff47 Author: Stephen Mallette <spmva@...> Date: 2018-10-01T20:02:46Z TINKERPOP-2053 Added OptionsStrategy Included a test in TinkerGraph rather than the main test suite because the test really isn't easily asserted without a custom step that reads the OptionsStrategy. commit 16c324e67686b5c7dbebe941928b56113048d21a Author: Stephen Mallette <spmva@...> Date: 2018-10-02T15:44:22Z TINKERPOP-2053 Python support for OptionsStrategy commit 334ea8ae9a1c1168f285d43afcb9b71c836febe7 Author: Stephen Mallette <spmva@...> Date: 2018-10-02T16:42:49Z TINKERPOP-2053 Added OptionsStrategy support for .NET commit 9b155132eb80efec52a34bf912ee2e247bc005b5 Author: Stephen Mallette <spmva@...> Date: 2018-10-02T17:55:21Z TINKERPOP-2053 Added upgrade docs for OptionsStrategy ---- > Provider OptionsStrategy for traversal configurations > ----------------------------------------------------- > > Key: TINKERPOP-2053 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2053 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.3.3 > Reporter: stephen mallette > Assignee: stephen mallette > Priority: Major > Fix For: 3.4.0 > > > {{OptionsStrategy}} will make it so that users can set traversal-wide options > that can be accessed by steps or other classes that might interact with a > {{Traversal}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)