[ 
https://issues.apache.org/jira/browse/TINKERPOP-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635944#comment-16635944
 ] 

ASF GitHub Bot commented on TINKERPOP-2041:
-------------------------------------------

Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/944#discussion_r222063562
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Text.java
 ---
    @@ -0,0 +1,123 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.tinkerpop.gremlin.process.traversal;
    +
    +import java.util.function.BiPredicate;
    +
    +/**
    + * @author Daniel Kuppitz (http://gremlin.guru)
    + */
    +public enum Text implements BiPredicate<String, String> {
    --- End diff --
    
    Could you please complete all the javadoc on this class since it's public 
facing like `Compare` - I think you need all the `@since` tags on everything in 
here.


> Text Predicates
> ---------------
>
>                 Key: TINKERPOP-2041
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2041
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.4.0
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>            Priority: Major
>
> Provide these simple text predicates:
>  * {{startsWith}}
>  * {{endsWith}}
>  * {{contains}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to