[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639798#comment-16639798
]
ASF GitHub Bot commented on TINKERPOP-1959:
-------------------------------------------
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/952#discussion_r222996609
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
---
@@ -216,14 +219,18 @@ class DriverRemoteConnection extends RemoteConnection
{
return args.map(val => this._adaptArgs(val));
}
+ if (args instanceof t.EnumValue) {
--- End diff --
It would be nice to handle it in a more elegant way, maybe:
```javascript
_adaptArgs(args) {
let newObj = {};
Object.keys(args).forEach((key) => {
newObj[key] = this._writer.adaptObject(args[key]);
});
return newObj;
}
```
From what I understand, `args` must be serialized as a JSON Object, where
each property value is in GraphSON2/3.
> Provide a way to submit scripts to the server in gremlin-javascript
> -------------------------------------------------------------------
>
> Key: TINKERPOP-1959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1959
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.2.8
> Reporter: stephen mallette
> Priority: Critical
>
> It is currently only possible to submit bytecode based requests to the server
> with gremlin-javascript. We should also provide some means for submitting
> scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
