[ 
https://issues.apache.org/jira/browse/TINKERPOP-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659531#comment-16659531
 ] 

ASF GitHub Bot commented on TINKERPOP-2071:
-------------------------------------------

spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set 
graphson deserializer should return a python set
URL: https://github.com/apache/tinkerpop/pull/964#issuecomment-431882499
 
 
   Thanks for submitting this....Travis seems unhappy on the gremlin-python 
version of the build....could you please have a look at that? Also, this looks 
like it needs a rebase now that we have the tp33 branch re-opened for 
development. That should get CHANGELOG setup for new entries. Please don't 
include the JIRA issue there - just a bullet point with your representation of 
what changed will suffice. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> gremlin-python: the graphson deserializer for g:Set should return a python set
> ------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2071
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2071
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: python
>    Affects Versions: 3.3.3
>            Reporter: Alan Boudreault
>            Assignee: stephen mallette
>            Priority: Major
>
> This is something that has already been discussed. The reason that a g:Set is 
> deserialized to a list is because Java can return some numerical values that 
> are not differentiate by python. See TINKERPOP-1844 for more details.
> However, I think this is is not something very common so I would like to 
> propose another behavior:
> 1. By default, always return a python set as normal for g:Set
> 2. When we detect the case described, log a warning and return a python list.
> 3. Document properly the limitation and the behavior of g:Set.
> Already discussed with Stephen and we think it's an acceptable behavior. I 
> will provide a PR shortly.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to