[ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661404#comment-16661404
 ] 

ASF GitHub Bot commented on TINKERPOP-2078:
-------------------------------------------

spmallette opened a new pull request #968: TINKERPOP-2078 Added ReferenceGraph
URL: https://github.com/apache/tinkerpop/pull/968
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2078
   
   Basically replaces `EmptyGraph.instance().withRemote()` for 
`ReferenceGraph.open().withRemote()` which is a bit more intuitive.
   
   ```text
   gremlin> graph = ReferenceGraph.open()
   ==>referencegraph[reference]
   gremlin> g = graph.traversal().withRemote('conf/remote-graph.properties')
   ==>graphtraversalsource[referencegraph[reference], standard]
   gremlin> g.addV('person').property('name','stephen')
   ==>v[16]
   gremlin> g.V().valueMap()
   ==>[name:[stephen]]
   ==>[name:[marko],age:[29]]
   ==>[name:[vadas],age:[27]]
   ==>[name:[lop],lang:[java]]
   ==>[name:[josh],age:[32]]
   ==>[name:[ripple],lang:[java]]
   ==>[name:[peter],age:[35]]
   ```
   
   Builds with `mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> ReferenceGraph rather than EmptyGraph or RemoteGraph
> ----------------------------------------------------
>
>                 Key: TINKERPOP-2078
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure
>    Affects Versions: 3.3.4
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Major
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. Create {{ReferenceGraph}} which 
> sets up some 4.x concepts (given current thinking). For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to