[
https://issues.apache.org/jira/browse/TINKERPOP-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676626#comment-16676626
]
ASF GitHub Bot commented on TINKERPOP-1984:
-------------------------------------------
spmallette opened a new pull request #987: TINKERPOP-1984 Enable GraphSON
serializers to no longer conflict
URL: https://github.com/apache/tinkerpop/pull/987
https://issues.apache.org/jira/browse/TINKERPOP-1984
Making `GraphSONMessageSerializerV2d0` handle both typed and untyped formats
allows it to be used in a fashion where users can choose to add serializers
with `application/json` at the same time for HTTP use cases. It also generally
seemed to make more sense than how it was before. Not sure what changed to
allow this now and not in the past.
Note the upgrade docs for why this is considered a breaking change - fairly
minor I think.
All tests pass with `docker/build.sh -t -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow support for multiple serializer versions in Gremlin Server HTTP
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-1984
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1984
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.3
> Reporter: stephen mallette
> Priority: Minor
> Labels: breaking, deprecation
>
> The {{HttpGremlinEndPointHandler}} only deals with {{MessageTextSerializer}}
> implementations and you can't configure multiple GraphSON ones because all of
> those implementations bind to {{application/json}} mimetype. I'm not even
> quite sure why a distinction exists anymore between "text" and "binary"
> serialization because we serialize to string only to turn around and convert
> to a {{ByteBuf}} which is what the binary version of the serializers already
> do.
> This is a breaking change because the header mime type appended to requests
> generated from {{GraphSONMessageSerializerV2d0}} changed from
> {{application/json}} to {{application/vnd.gremlin-v2.0+json}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
