I think I figured out how to ignore those directories. Had to override the default apache parent pom source distribution process - it didn't take into account non-JVM file stuffs. I didn't see where it was easily accessible to extend so I just overrode the whole thing. Just pushed a fix on tp33 and master.
https://github.com/apache/tinkerpop/commit/28b63228fe09c12787ee5c96159fe6b97a774284 Can someone please confirm that all is good before I go through 3.3.5 release again (for a third time <dah>)? On Thu, Jan 3, 2019 at 11:54 AM Daniel Kuppitz <m...@gremlin.guru> wrote: > rm -rf gremlin-dotnet/src/{obj,_site} > rm -rf > gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules > > This helps to get a clean build, git clean seems to be the better choice > though. > However, I have no clue how we can control the contents of the src zip > file, I don't even know which of then maven plugin creates it. > > Cheers, > Daniel > > > > On Thu, Jan 3, 2019 at 9:04 AM Robert Dale <robd...@gmail.com> wrote: > > > Maybe anything generated should be excluded: > > > > src/docfx > > src/gremlin-dotnet-source.iml > > src/Gremlin.Net/Driver/obj > > src/Gremlin.Net.Template.3.3.4.nupkg > > src/nuget-4.4.1.exe > > src/obj > > src/_site > > .vscode > > > > or better yet, 'git clean -fdx' before building the src zip. I haven't > > looked at the src zip build process so I'm not sure if that's compatible. > > > > Robert Dale > > > > > > On Thu, Jan 3, 2019 at 10:34 AM Daniel Kuppitz <m...@gremlin.guru> wrote: > > > > > I just found this entry in my log: > > > > > > [exec] [19-01-03 03:20:16.409]Error:System.AggregateException: One > > or > > > more errors occurred. > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/hlxtywvr.c9b > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/b2ia4mzc.9sx > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/2d1bhm1s.w5c > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/1ujoqpgt.8fv > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/7wgceclr.f8o > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/6xipa4ui.3bf > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/dz43j9do.zik > > > does not exist) > > > > > > > > > (/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/32w60ckf.kxh > > > does not exist) ---> System.IO.FileNotFoundException: > > > > > > > > > /home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/hlxtywvr.c9b > > > does not exist > > > > > > I guess the gremlin-dotnet/src/Gremlin.Net/Driver/obj/xdoc/cache > > directory > > > shouldn't be part of the zip (maybe not even > > > gremlin-dotnet/src/Gremlin.Net/Driver/obj). > > > > > > > > > On Thu, Jan 3, 2019 at 8:01 AM Daniel Kuppitz <m...@gremlin.guru> wrote: > > > > > > > Confirmed, building the tag just worked for me, too. > > > > > > > > > > > > On Thu, Jan 3, 2019 at 7:59 AM Robert Dale <robd...@gmail.com> > wrote: > > > > > > > >> Building the tag from github works fine. Looks like some local > build > > > >> artifacts snuck into the src.zip. > > > >> > > > >> Excluding gremlin-dotnet, validate-distribution passes. > > > >> > > > >> Robert Dale > > > >> > > > >> > > > >> On Thu, Jan 3, 2019 at 9:49 AM Robert Dale <robd...@gmail.com> > wrote: > > > >> > > > >> > Daniel, I had to install 'msbuild' in addition to the mono > packages. > > > I > > > >> > also installed mono-addins-devel. I don't know if that actually > did > > > >> > anything. > > > >> > > > > >> > But now I get some errors with : > > > >> > > > > >> > System.IO.FileNotFoundException: > > > >> > > > > > > */home/smallette*/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/2d1bhm1s.w5c > > > >> > does not exist > > > >> > > > > >> > > > > >> > Robert Dale > > > >> > > > > >> > > > > >> > On Thu, Jan 3, 2019 at 9:43 AM Daniel Kuppitz <m...@gremlin.guru> > > > wrote: > > > >> > > > > >> >> I skimmed over the docs, they look good to me, but the > > > >> >> validate-distribution.sh script fails the same way as for Robert. > > > >> >> > > > >> >> Investigating.... > > > >> >> > > > >> >> Cheers, > > > >> >> Daniel > > > >> >> > > > >> >> > > > >> >> On Wed, Jan 2, 2019 at 2:58 PM Stephen Mallette < > > > spmalle...@gmail.com> > > > >> >> wrote: > > > >> >> > > > >> >> > Hello, > > > >> >> > > > > >> >> > We are happy to announce that TinkerPop 3.3.5 is ready for > > release. > > > >> >> > > > > >> >> > The release artifacts can be found at this location: > > > >> >> > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.3.5/ > > > >> >> > > > > >> >> > The source distribution is provided by: > > > >> >> > apache-tinkerpop-3.3.5-src.zip > > > >> >> > > > > >> >> > Two binary distributions are provided for user convenience: > > > >> >> > apache-tinkerpop-gremlin-console-3.3.5-bin.zip > > > >> >> > apache-tinkerpop-gremlin-server-3.3.5-bin.zip > > > >> >> > > > > >> >> > The GPG key used to sign the release artifacts is available at: > > > >> >> > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > > >> >> > > > > >> >> > The online docs can be found here: > > > >> >> > http://tinkerpop.apache.org/docs/3.3.5/ (user docs) > > > >> >> > http://tinkerpop.apache.org/docs/3.3.5/upgrade/ > (upgrade > > > >> docs) > > > >> >> > http://tinkerpop.apache.org/javadocs/3.3.5/core/ (core > > > >> javadoc) > > > >> >> > http://tinkerpop.apache.org/javadocs/3.3.5/full/ (full > > > >> javadoc) > > > >> >> > > > > >> >> > The tag in Apache Git can be found here: > > > >> >> > https://github.com/apache/tinkerpop/tree/3.3.5 > > > >> >> > > > > >> >> > The release notes are available here: > > > >> >> > > > > >> >> > https://github.com/apache/tinkerpop/blob/3.3.5/CHANGELOG.asciidoc > > > >> >> > > > > >> >> > The [VOTE] will be open for the next 72 hours --- closing > > Saturday > > > >> >> (January > > > >> >> > 5, 2018) at 5pm EST. > > > >> >> > > > > >> >> > My vote is +1. > > > >> >> > > > > >> >> > Thank you very much, > > > >> >> > > > > >> >> > Stephen > > > >> >> > > > > >> >> > > > >> > > > > >> > > > > > > > > > >
