[
https://issues.apache.org/jira/browse/TINKERPOP-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779409#comment-16779409
]
ASF GitHub Bot commented on TINKERPOP-2166:
-------------------------------------------
jorgebay commented on pull request #1073: TINKERPOP-2166 Cache expression to
obtain the method in PSerializer
URL: https://github.com/apache/tinkerpop/pull/1073
https://issues.apache.org/jira/browse/TINKERPOP-2166
Implement a cache for the search of the method in P deserialization.
Includes a micro benchmark:
Before:
```
Benchmark Mode Cnt Score Error
Units
GraphBinaryReaderWriterBenchmark.readP1 thrpt 20 74574.850 ± 2466.040
ops/s
```
With this patch:
```
Benchmark Mode Cnt Score Error
Units
GraphBinaryReaderWriterBenchmark.readP1 thrpt 20 1483588.719 ± 77339.678
ops/s
```
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GraphBinary: P deserialization should be optimized
> --------------------------------------------------
>
> Key: TINKERPOP-2166
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2166
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
> Reporter: Jorge Bay
> Assignee: Jorge Bay
> Priority: Major
>
> P deserialization on GraphSON3 and GraphBinary can be optimized by using
> caching / casting, avoiding expensive reflection calls when possible.
> This ticket is to track the GraphBinary implementation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
