[ 
https://issues.apache.org/jira/browse/TINKERPOP-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788337#comment-16788337
 ] 

Divij Vaidya commented on TINKERPOP-2173:
-----------------------------------------

I was working around this code base for a different issue so I fixed it. It is 
part of the pull request: [https://github.com/apache/tinkerpop/pull/1081]

> Incorrect reset of log level in integration test
> ------------------------------------------------
>
>                 Key: TINKERPOP-2173
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2173
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Divij Vaidya
>            Priority: Trivial
>
> This issue is regarding GremlinServerIntegrateTest.java and other similar 
> tests.
> In the @After method, the intention is to reset the log level which was 
> temporarily changed in the @Before method for the duration of the test. 
> However, instead of resetting to the original state, the code ends up setting 
> the same log level again.
> Proposed fix:
> Do not mutate the previousLogLevel field in the @After methods [1][2]
> [1][https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java#L149]
>  
> [2][https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java#L124]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to