Sam Hard created TINKERPOP-2253:
-----------------------------------

             Summary: Special case for JToken 
                 Key: TINKERPOP-2253
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2253
             Project: TinkerPop
          Issue Type: Bug
          Components: dotnet
    Affects Versions: 3.4.0
            Reporter: Sam Hard


A recent change to Gremlin.Net, made to address TINKERPOP-2067, broke existing 
functionality for the downstream library Gremlin.Net.CosmosDb.  That library 
invokes Gremlin.Net.Driver.Connection's `SubmitAsync<T>()` method, sending 
`JToken` as the generic type argument, and expects the query results to be run 
through `_graphSONReader.ToObject()`, but that step is now specifically skipped 
just for `JToken`.

I propose that it would be better for Connection.SubmitAsync() to work the same 
for all types, as it did before, and that a new property in the class (or an 
optional method parameter) could be used to configure when the graphSON reader 
should be bypassed.

The breaking change was merged with this pull request:  
[https://github.com/apache/tinkerpop/pull/972]

As a cross-reference, the GitHub issue documenting the problem with 
Gremlin.Net.CosmosDb can be found here: 
[https://github.com/evo-terren/Gremlin.Net.CosmosDb/issues/49]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to