[
https://issues.apache.org/jira/browse/TINKERPOP-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927966#comment-16927966
]
ASF GitHub Bot commented on TINKERPOP-2213:
-------------------------------------------
spmallette commented on pull request #1191: TINKERPOP-2213 Deprecated
scriptEvaluationTimeout for evaluationTimeout
URL: https://github.com/apache/tinkerpop/pull/1191
https://issues.apache.org/jira/browse/TINKERPOP-2213
The `scriptEvaluationTimeout` still works from a configuration perspective
from both a client and server perspective. Used -1 to "disable"
`scriptEvaluationTimeout` in the server configuration to thus favor
`evaluationTimeout`. Setting `scriptEvaluationTimeout` directly to something
other -1 will force that value to be respected so there should be no breaking
changes here.
Builds with `mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace scriptEvaluationTimeout in favor of something more suitable to
> bytecode
> -------------------------------------------------------------------------------
>
> Key: TINKERPOP-2213
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2213
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.3.6
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Major
> Labels: breaking
>
> {{scriptEvaluationTimeout}} doesn't fit well with bytecode based requests
> because they aren't actually "scripts" - consider just {{evaluationTimeout}}?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
