[
https://issues.apache.org/jira/browse/TINKERPOP-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025962#comment-17025962
]
ASF GitHub Bot commented on TINKERPOP-2332:
-------------------------------------------
jorgebay commented on pull request #1242: TINKERPOP-2332 JavaScript GLV: Fix
structure toString() methods
URL: https://github.com/apache/tinkerpop/pull/1242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JavaScript GLV: structure element toString() should internally call toString()
> ------------------------------------------------------------------------------
>
> Key: TINKERPOP-2332
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2332
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
> Affects Versions: 3.3.9, 3.4.4
> Reporter: Jorge Bay
> Assignee: Jorge Bay
> Priority: Major
> Fix For: 3.4.5, 3.3.10
>
>
> Structure classes use String instance methods on properties that might not be
> strings.
> For example, current implementation:
> {code:javascript}
> class Property {
> // ...
> toString() {
> return 'p[' + this.key + '->' + this.value.substr(0, 20) + ']';
> }
> }
> {code}
> Should be:
> {code:javascript}
> class Property {
> // ...
> toString() {
> return 'p[' + this.key + '->' + this.value.toString().substr(0, 20) + ']';
> }
> }
> {code}
> Plus checking on null/undefined value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
