[ https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120178#comment-17120178 ]
ASF GitHub Bot commented on TINKERPOP-1641: ------------------------------------------- vtslab commented on pull request #1290: URL: https://github.com/apache/tinkerpop/pull/1290#issuecomment-636308564 I agree with this comment on the original PR: "I do think the hardcoded "3.5.0-SNAPSHOT" in docker-entrypoint.sh needs to be dynamically referenced." From the docker/gremlin-server/Dockerfile.template a GREMLIN_SERVER_VERSION variable is available from the environment. So, the offending line in docker-entrypoint.sh should read: ` java -cp /opt/gremlin-test/gremlin-test-${GREMLIN_SERVER_VERSION}-jar-with-dependencies.jar \ ` While testing this I found that docker/gremlin_server.sh did not run and I do not understand how it ever can have worked. Anyway, docker needs absolute paths for the mounts and I think the docker run line should read: ``` ABS_PROJECT_HOME=$(dirname $(realpath $0))/.. docker run ${TINKERPOP_TEST_DOCKER_OPTS} ${REMOVE_CONTAINER} -h gremlin-server-test -v "${HOME}"/.groovy:/root/.groovy \ -v "${HOME}"/.m2:/root/.m2 -v "${ABS_PROJECT_HOME}"/gremlin-test/target:/opt/gremlin-test -ti tinkerpop:${BUILD_TAG} ${@} ``` If you want I can put it in a PR against branch TINKERPOP-1641 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Kerberos authentication for gremlin-python > ------------------------------------------ > > Key: TINKERPOP-1641 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1641 > Project: TinkerPop > Issue Type: Improvement > Components: python > Affects Versions: 3.3.0 > Reporter: Marc de Lignie > Priority: Minor > > Enable kerberos authentication for gremlin-python. -- This message was sent by Atlassian Jira (v8.3.4#803005)