[jira] [Commented] (TINKERPOP-2391) Drop GLV Templating System

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/TINKERPOP-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171601#comment-17171601
 ] 

ASF GitHub Bot commented on TINKERPOP-2391:
-------------------------------------------

spmallette commented on a change in pull request #1302:
URL: https://github.com/apache/tinkerpop/pull/1302#discussion_r465851569



##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -33,14 +33,43 @@ limitations under the License.
 
     <build>
         <plugins>
-            <!-- Override the execution from gremlin-dotnet to disable code 
generation from happening a second time -->
             <plugin>
                 <groupId>org.codehaus.gmavenplus</groupId>
                 <artifactId>gmavenplus-plugin</artifactId>
+                <dependencies>
+                    <dependency>
+                        <groupId>org.codehaus.groovy</groupId>
+                        <artifactId>groovy-all</artifactId>
+                        <version>${groovy.version}</version>
+                        <type>pom</type>
+                        <scope>runtime</scope>
+                    </dependency>
+                </dependencies>
                 <executions>
                     <execution>
-                        <id>generate-dsl</id>
-                        <phase/>
+                        <id>update-version</id>
+                        <phase>generate-sources</phase>
+                        <goals>
+                            <goal>execute</goal>
+                        </goals>
+                        <configuration>
+                            <scripts>
+                                <script>
+def mavenVersion = "${project.version}"
+def rawVersion = mavenVersion.replace("-SNAPSHOT", "")
+def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+file.write(file.getText("UTF-8").replaceFirst(/&lt;Version&gt;(.*)&lt;\/Version&gt;/,
 "&lt;Version&gt;" + mavenVersion + "&lt;/Version&gt;").
+                                 
replaceFirst(/&lt;FileVersion&gt;(.*)&lt;\/FileVersion&gt;/, 
"&lt;FileVersion&gt;" + rawVersion + ".0&lt;/FileVersion&gt;").

Review comment:
       thanks for the reference with that blog post. amazing how many 
"versions" .net has. wow. i opted to remove the two elements.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Drop GLV Templating System
> --------------------------
>
>                 Key: TINKERPOP-2391
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2391
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release
>    Affects Versions: 3.5.0
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Minor
>
> The GLV template system is not really helpful to the ongoing maintenance of 
> GLVs especially since we now have a unified test system for it. Remove the 
> templates for 3.5.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)