[ https://issues.apache.org/jira/browse/TINKERPOP-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172358#comment-17172358 ]
ASF GitHub Bot commented on TINKERPOP-2389: ------------------------------------------- vtslab opened a new pull request #1308: URL: https://github.com/apache/tinkerpop/pull/1308 [https://issues.apache.org/jira/browse/TINKERPOP-2389](https://issues.apache.org/jira/browse/TINKERPOP-2389) This work is by no means finished, but is a first shot along the lines of the discussion linked to in the JIRA ticket. The work includes and Authorized API, called from the AbstractChannelizer, as well as a small WhitelistAuthorizer demo implementation included in the gremlin-server tests. The current WIP PR is only intended to simplify a review of this first concept. As the RequestMessage object passed to the authorize() method is not easy to handle, I thought it useful to do some first preprocessing common to future Authorizer implementations: - split authorization requests in those for bytecode requests and those for string-based requests - get and cast the object corresponding to Token.ARGS_GREMLIN This is not entirely consistent though as the other Token.ARGS_XYZ are left unpacked in the original RequestMessage. Any feedback is welcomed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Authorization support in TinkerPop > ---------------------------------- > > Key: TINKERPOP-2389 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2389 > Project: TinkerPop > Issue Type: Improvement > Components: server > Affects Versions: 3.4.7 > Reporter: Shekhar Bansal > Priority: Major > Attachments: Screenshot 2020-06-25 at 15.15.04.png > > > Use case: > # Tinkerpop supports multiple graphs using a single API and admin might want > to restrict access to some of the graphs. > # Admin might want to restrict read/write access to certain users. > > Proposal > Add read/write access restrictions at graph level. We can extend it to > executing scripts by adding execute privileges. > > Changes required > Add `authorizer` block similar to `authentication` block in yaml file > > {code:java} > authorization: { > authorizer: > org.apache.tinkerpop.gremlin.server.authorization.AllowAllAuthorizer, > authorizationHandler: > org.apache.tinkerpop.gremlin.server.handler.SaslAuthorizationHandler, > config: { > } > }{code} > > Authorization will be done only if authentication is enabled. Authentication > is done at per session basis while authorization will be done for each and > every request. > In `SaslAuthorizationHandler` or `HttpAuthorizationHandler` query will be > parsed and depending on the step instructions, the query will be marked as of > type read or write and then privilege evaluation will be done by calling > `isAccessAllowed` method of `Authorizer` > {code:java} > public interface Authorizer { > /** > * Whether or not the authorization requires check. > * If false will not authorzie user. > */ > public boolean requireAuthorization(); > /** > * Setup is called once upon system startup to initialize the {@code > Authorizer}. > */ > public void setup(final Map<String, Object> config); > /** > * A "standard" authorization implementation > */ > public boolean isAccessAllowed(AuthorizationRequest authorizationRequest) > throws AuthorizationException; > } > {code} > Access policies can be defined in tools like `Apache Ranger`, sample policy: > !Screenshot 2020-06-25 at 15.15.04.png|width=1017,height=548! > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)