[
https://issues.apache.org/jira/browse/TINKERPOP-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189271#comment-17189271
]
ASF GitHub Bot commented on TINKERPOP-2413:
-------------------------------------------
spmallette opened a new pull request #1322:
URL: https://github.com/apache/tinkerpop/pull/1322
https://issues.apache.org/jira/browse/TINKERPOP-2413
Deprecated `withGraph()` on `AnonymousTraversalSource` in favor of
`withEmbedded()`. Didn't really alter tests so as to keep testing running
through the old deprecated method which basically just proxies to
`withEmbedded()`. GLVs didn't need much change since there really is no
"embedded" option there. For python and .NET, i changed nothing since there is
no embedded version. For javascript I explicitly deprecated `withGraph()` and
fixed up jsdoc a bit. Modified documentation to better promote `withEmbedded()`
- not sure why we didn't do that for `withGraph()` long ago (perhaps the idea
was to wait for 3.5.0, but in a way I'm sorta glad we didn't as we've now
deprecated.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Prefer withEmbedded() to withGraph() on AnonymousTraversalSource
> ----------------------------------------------------------------
>
> Key: TINKERPOP-2413
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2413
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.4.8
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
> Labels: deprecation
>
> Deprecate {{traversal().withGraph(Graph)}} and prefer
> {{traversal().withEmbedded(Graph)}} as a more explicit alternative to the API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
