Divij Vaidya created TINKERPOP-2427:
---------------------------------------

             Summary: Simplify Netty reference counting
                 Key: TINKERPOP-2427
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2427
             Project: TinkerPop
          Issue Type: Improvement
          Components: driver
    Affects Versions: 3.4.8, 3.5.0
            Reporter: Divij Vaidya


We have some incorrect configuration in the code such as:
[https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketGremlinResponseDecoder.java#L59]
 (MessageToMessageDecoder automatically decreases the reference count).

[https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java#L270]
 (SimpleChannelInboundHandler automatically decreases the reference count).

which are fixed by hardcoding values such as:
[https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java#L89]

This Jira will fix the reference counting correctly and eliminate the need for 
hardcoding.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to