[
https://issues.apache.org/jira/browse/TINKERPOP-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213986#comment-17213986
]
ASF GitHub Bot commented on TINKERPOP-2436:
-------------------------------------------
spmallette edited a comment on pull request #1342:
URL: https://github.com/apache/tinkerpop/pull/1342#issuecomment-708463050
> I do not have change the Upgrade Documentation as this GraphManager is not
the default, so it will not break anything. An option is to set like it in 3.4
branch and to make it default in master.
See item 2 above. I was offering you the option to change to your new one.
If you want to point this PR at `3.4-dev` then true, you don't need Upgrade
documentation.
> Also, why does DefaultGraphManager was final (class and methods), this
make harder to do a extension on this class. I have only removed final on class
(I like the Jetty approach that allows override at nearly any level)
I made mention of this in item 1 - "You will need to alter
DefaultGraphManager scopes to make this work". Yes, you will need to make
`DefaultGraphManager` more extensible by removing `final`, changing member
variable scopes to `protected`, etc. There were reasons for doing it that way
initially, but I don't think they apply so much anymore.....plus, you are now
adding this change, so time to open it up for extension.
I think I would also add another item:
8. Reference documentation should probably refer to the two options we have
after your change. You could just update the `graphManager` key in the Gremlin
Server Configuration section
[here](https://github.com/apache/tinkerpop/blob/501e926afd5dd956b2c2c823c5304978f732d54f/docs/src/reference/gremlin-applications.asciidoc#configuring).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The gremlin server starts even if all graphs instantiation has failed
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-2436
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2436
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Nicolas Trangosi
> Priority: Major
>
> Sometimes the gremlin server fails to open the graph due to backend failure.
> In this case, gremlin server starts even if could not serve any request as
> gremlin-groovy GremlinScriptEngine is not initialized. I think that in this
> case, gremlin server should stop (and be restarted in a kubernates cluster)
> {{8 Oct 2020 12:35:51,923 8660 [gremlin-server-exec-1] ERROR
> org.apache.tinkerpop.gremlin.jsr223.DefaultGremlinScriptEngineManager -
> Could not create GremlinScriptEngine for gremlin-groovy}}
> {{ java.lang.IllegalStateException: javax.script.ScriptException:
> javax.script.ScriptException: groovy.lang.MissingPropertyException: No such
> property: graph for class: Script1 }}
> {noformat}
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> java.lang.RuntimeException: GraphFactory could not instantiate this Graph
> implementation [class org.janusgraph.core.JanusGraphFactory]
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:81)
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:69)
> at ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
