[
https://issues.apache.org/jira/browse/TINKERPOP-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261231#comment-17261231
]
Aditya Srivastava commented on TINKERPOP-2501:
----------------------------------------------
I looked into this further and it seems to me it's double logging, one in event
log 'log' and another in 'socketError' and the error event was changed from
*error* to *socketError* few years back. So, I am going to catch errors via
socketError error and not rely on the *log* event.
ref:https://github.com/apache/tinkerpop/commit/78819c3efa97f87ddc55da8e9e4543d661f4d1ec
Thanks for looking into it [~spmallette] but we should be good here.
> Websocket Connection handleError in javascript gremlin driver emits 'log'
> event instead of 'error'
> --------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2501
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2501
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
> Reporter: Aditya Srivastava
> Priority: Minor
>
> *Description*
> Javascript gremlin module has one weird logging behavior during client
> connection setup.
> The webSocket error event emits a *handleError* function
> [https://github.com/apache/tinkerpop/blob/64ec9fbc9e6d368f1a251b25cf7b120ace09298c/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L155]
> and this function emits the error message under *log* event i.e
> [https://github.com/apache/tinkerpop/blob/64ec9fbc9e6d368f1a251b25cf7b120ace09298c/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L235].
> It looks like this was broken recently by
> [https://github.com/apache/tinkerpop/commit/ab43b03514cf82fa004653c3a0d082e8a744107d]
> this commit.
> I believe this should ideally be thrown under *error* event. Right now we
> have to listen to these connection errors under *log* event.
> I'll be happy to raise a pr for this once the bug gets approved by the core
> team.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
