[
https://issues.apache.org/jira/browse/TINKERPOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316630#comment-17316630
]
ASF GitHub Bot commented on TINKERPOP-2457:
-------------------------------------------
divijvaidya commented on a change in pull request #1413:
URL: https://github.com/apache/tinkerpop/pull/1413#discussion_r609036552
##########
File path:
gremlin-python/src/main/jython/gremlin_python/driver/tornado/transport.py
##########
@@ -26,21 +26,25 @@
class TornadoTransport(AbstractBaseTransport):
+ _default_max_content_length = 10 * 1024 * 1024
Review comment:
This is probably a breaking change and should go either in 350 or in
3411 with same default as current version. In absence of explicitly setting
this value, the default must be coming from the websocket framework.
This is breaking because let's say that the current default is 20MB and a
user of the client is relying on that but when we introduce a new default value
of 10MB, after upgrade, their queries will suddenly start failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a max_content_length parameter to DriverRemoteConnection in the Python
> client
> ---------------------------------------------------------------------------------
>
> Key: TINKERPOP-2457
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2457
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.4.8
> Reporter: Kelvin R. Lawrence
> Priority: Major
>
> I was recently trying to retrieve a subgraph (basically just the air-routes
> part of the air-routes data set) using Gremlin Python over Web Sockets. My
> query kept failing. After some investigation I discovered that the default
> maximum result set for Tornado is 10*1024*1024 (10 gig)
> The current Python client does not offer a way to override this from an
> application. I would like to propose that we add a `max_content_length`
> parameter to the constructor for DriverRemoteConnection so that one could do
> something like:
> {code:java}
> connection = DriverRemoteConnection(
> endpoint,
> 'g',
> max_content_length=1024 ** 3){code}
>
> I coded up a prototype for this and it seems to work well. I did not
> investigate if we need to also provide such a setting when connecting via
> HTTP yet.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
