[
https://issues.apache.org/jira/browse/TINKERPOP-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355300#comment-17355300
]
ASF GitHub Bot commented on TINKERPOP-2551:
-------------------------------------------
spmallette opened a new pull request #1424:
URL: https://github.com/apache/tinkerpop/pull/1424
https://issues.apache.org/jira/browse/TINKERPOP-2551
Should allow the deploy to npm by way of that maven plugin. Adjusted the Rat
plugin exclusions a bit. Fixed NOTICE copyright years. Pointed this at 3.5-dev
so that it could get its first deploy at 3.5.1. I suppose that's alright.
Perhaps we do a 3.5.1-alpha1 to test the deploy process - that can be discussed
on dev.
Builds nicely with `mvn clean install` and `mvn clean install -pl gremlint`
- output as follows;
```
$ mvn clean install -pl gremlint
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.tinkerpop:gremlint
>--------------------
[INFO] Building Apache TinkerPop :: Gremlin Javascript 3.5.1-SNAPSHOT
[INFO] --------------------------------[ jar
]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ gremlint ---
[INFO] Deleting /home/smallette/git/apache/tinkerpop/gremlint/target
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @
gremlint ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-all) @ gremlint
---
[INFO]
[INFO] --- build-helper-maven-plugin:3.0.0:regex-property
(build-helper-regex-is-snapshot-used) @ gremlint ---
[INFO]
[INFO] --- build-helper-maven-plugin:3.0.0:regex-property
(build-helper-regex-is-prerelease-version) @ gremlint ---
[INFO]
[INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @
gremlint ---
[INFO]
[INFO] --- apache-rat-plugin:0.13:check (rat-checks) @ gremlint ---
[INFO] Added 1 additional default licenses.
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from
/home/smallette/git/apache/tinkerpop/gremlint/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 67 implicit excludes (use -debug for more details).
[INFO] 59 explicit excludes (use -debug for more details).
[INFO] 40 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0,
generated: 0, approved: 38 licenses.
[INFO]
[INFO] --- buildnumber-maven-plugin:1.4:create (default) @ gremlint ---
[INFO] Executing: /bin/sh -c cd
'/home/smallette/git/apache/tinkerpop/gremlint' && 'git' 'rev-parse' '--verify'
'HEAD'
[INFO] Working directory: /home/smallette/git/apache/tinkerpop/gremlint
[INFO] Storing buildNumber: cca37aa7339937a74814c2d6c55ff54e6e9ba150 at
timestamp: 1622570961163
[INFO] Storing buildScmBranch: 3.5-dev
[INFO]
[INFO] --- gmavenplus-plugin:1.11.0:execute (update-version) @ gremlint ---
[INFO] Using plugin classloader, includes GMavenPlus classpath.
[INFO] Using Groovy 2.5.14 to perform execute.
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process
(process-resource-bundles) @ gremlint ---
[INFO]
[INFO] --- frontend-maven-plugin:1.10.0:install-node-and-npm (install node
and npm) @ gremlint ---
[INFO] Node v10.22.0 is already installed.
[INFO] NPM 6.14.6 is already installed.
[INFO]
[INFO] --- frontend-maven-plugin:1.10.0:npm (npm install) @ gremlint ---
[INFO] Running 'npm install' in /home/smallette/git/apache/tinkerpop/gremlint
[INFO]
[INFO] > gremlint@3.5.1-alpha1 prepare
/home/smallette/git/apache/tinkerpop/gremlint
[INFO] > npm run build
[INFO]
[INFO]
[INFO] > gremlint@3.5.1-alpha1 build
/home/smallette/git/apache/tinkerpop/gremlint
[INFO] > tsc
[INFO]
[INFO] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.3.2
(node_modules/fsevents):
[INFO] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform
for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current:
{"os":"linux","arch":"x64"})
[INFO]
[INFO] removed 91 packages and audited 510 packages in 6.683s
[INFO]
[INFO] 24 packages are looking for funding
[INFO] run `npm fund` for details
[INFO]
[INFO] found 0 vulnerabilities
[INFO]
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @
gremlint ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/home/smallette/git/apache/tinkerpop/gremlint/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ gremlint
---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:testResources
(default-testResources) @ gremlint ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/home/smallette/git/apache/tinkerpop/gremlint/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
gremlint ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.21.0:test (default-test) @ gremlint ---
[INFO]
[INFO] --- frontend-maven-plugin:1.10.0:npm (npm test) @ gremlint ---
[INFO] Running 'npm test --exit' in
/home/smallette/git/apache/tinkerpop/gremlint
[INFO]
[INFO] > gremlint@3.5.1-alpha1 test
/home/smallette/git/apache/tinkerpop/gremlint
[INFO] > jest --config jestconfig.json
[INFO]
[INFO] PASS src/formatQuery/__tests__/modulatorIndentation.test.ts
[INFO] PASS src/formatQuery/__tests__/closureIndentation.test.ts
[INFO] PASS src/formatQuery/__tests__/multipleQueriesAtOnce.test.ts
[INFO] PASS
src/formatQuery/parseToSyntaxTrees/__tests__/extractGremlinQueries.test.ts
[INFO] PASS src/formatQuery/__tests__/curlyBracketWrapping.test.ts
[INFO] PASS src/formatQuery/__tests__/curlyBracketMultilineWrapping.test.ts
[INFO] PASS src/formatQuery/__tests__/modulatorWrapping.test.ts
[INFO] PASS
src/formatQuery/__tests__/determineWhatPartsOfCodeAreGremlin.test.ts
[INFO] PASS
src/formatQuery/__tests__/invalidIndentationAndMaxLineLength.test.ts
[INFO] PASS src/formatQuery/__tests__/defaultConfig.test.ts
[INFO] PASS src/formatQuery/__tests__/dotsAfterLineBreaks.test.ts
[INFO] PASS src/formatQuery/__tests__/nonMethodIndentation.test.ts
[INFO] PASS src/formatQuery/__tests__/maxLineLength.test.ts
[INFO] PASS src/formatQuery/__tests__/nonGremlinIndentation.test.ts
[INFO]
[INFO] Test Suites: 14 passed, 14 total
[INFO] Tests: 14 passed, 14 total
[INFO] Snapshots: 0 total
[INFO] Time: 1.477 s
[INFO] Ran all test suites.
[INFO]
[INFO] --- maven-jar-plugin:3.0.2:jar (default-jar) @ gremlint ---
[INFO] Building jar:
/home/smallette/git/apache/tinkerpop/gremlint/target/gremlint-3.5.1-SNAPSHOT.jar
[INFO]
[INFO] --- maven-source-plugin:3.0.1:jar-no-fork (attach-sources) @ gremlint
---
[INFO] Skipping source per configuration.
[INFO]
[INFO] --- maven-javadoc-plugin:3.1.0:jar (attach-javadoc) @ gremlint ---
[INFO] Skipping javadoc generation
[INFO]
[INFO] --- maven-site-plugin:3.7.1:attach-descriptor (attach-descriptor) @
gremlint ---
[INFO] Skipping because packaging 'jar' is not pom.
[INFO]
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ gremlint
---
[INFO] Skipping artifact installation
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 11.861 s
[INFO] Finished at: 2021-06-01T14:09:31-04:00
[INFO]
------------------------------------------------------------------------
```
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setup scripts to publish Gremint to npm
> ---------------------------------------
>
> Key: TINKERPOP-2551
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2551
> Project: TinkerPop
> Issue Type: Improvement
> Components: gremlint
> Affects Versions: 3.5.0
> Reporter: Øyvind Sæbø
> Priority: Major
>
> Currently The gremlint web app at tinkerpop.apache.org/gremlint still
> installs the gremlint library from github:OyvindSabo/gremlint#master. In the
> tinkerpop repo, however, gremlint is not located in the root directory, so
> installing it as a package directly from GitHub with npm is as far as I know
> not possible.
> It would be nice to get gremlint published to npm so that it's easier for
> users to use it in JavaScript projects, and so that the gremlint web app can
> use the latest code from tinkerpop/gremlint, rather than installing the no
> longer maintained code from OyvindSabo/gremlint.
> I assume this will have to be done similarly to how it's done for
> gremlin-javascript, although I haven't had time to look closely at how that's
> done yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
