[
https://issues.apache.org/jira/browse/TINKERPOP-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355432#comment-17355432
]
Stephen Mallette commented on TINKERPOP-2574:
---------------------------------------------
we usually just set the "affects version" to the oldest version where we see
the problem (so typically just one value there and in this case would be 3.4.11
- sorry, shouldn't have said 3.3.11 originally). we usually set the fix version
when we close the issue and set it to all the versions within which it was
fixed. for this particular situation, you have a pretty simple administrative
change. i think you would be within rights to have not bothered to create a
JIRA and just did a commit/push as CTR - see the last bullet point in this
section: https://tinkerpop.apache.org/docs/current/dev/developer/#rtc
So, you would checkout 3.4-dev, make your change, commit locally with "CTR" in
the comment (like i did earlier today
[here|https://github.com/apache/tinkerpop/commit/f44f2c0994d432399dd58ed1fe9d271fa8409a9b]
as an example). then, basically:
{code}
git checkout 3.5-dev
git merge 3.4-dev
git checkout master
git merge 3.5-dev
{code}
then push in reverse order:
{code}
git push origin master
git push origin 3.5-dev
git push origin 3.4-dev
{code}
> Don't gitignore package-lock.json
> ---------------------------------
>
> Key: TINKERPOP-2574
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2574
> Project: TinkerPop
> Issue Type: Improvement
> Components: gremlint, javascript
> Affects Versions: 3.5.0, 3.3.11, 3.4.11
> Reporter: Øyvind Sæbø
> Assignee: Øyvind Sæbø
> Priority: Trivial
> Fix For: 3.5.0, 3.3.11, 3.4.11
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Creating this task as a follow-up to
> https://issues.apache.org/jira/browse/TINKERPOP-2572.
> To make sure the result of running npm install is deterministic,
> package-lock.json should be committed along with package.json instead of
> being gitignored. This will prevent older package-lock.json files that may
> exist locally from earlier installs from being used to determine what
> versions to install when running npm install.
> I'm not 100% sure I understand how the Affects Version and Fix Version fields
> should be set when creating the Jira ticket. Feedback appreciated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
