[
https://issues.apache.org/jira/browse/TINKERPOP-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette closed TINKERPOP-2565.
---------------------------------------
Fix Version/s: 3.6.0
3.5.1
3.4.12
Assignee: Stephen Mallette
Resolution: Fixed
Fixed via CTR with
https://github.com/apache/tinkerpop/commit/5538770599a979212b56e2dcb77308a60ff656a4
> GraphMLWriter does not check vertexLabelKey conflict
> ----------------------------------------------------
>
> Key: TINKERPOP-2565
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2565
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.4.11
> Reporter: Luz
> Assignee: Stephen Mallette
> Priority: Minor
> Fix For: 3.4.12, 3.5.1, 3.6.0
>
>
> Reading the GraphMLWriter code I came across [these weird lines of
> code|https://github.com/apache/tinkerpop/blob/74a492c043c64db33bb5a12a2dc6eaea253b3684/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java#L175]:
> {code:java}
> if (identifiedEdgeKeyTypes.containsKey(this.edgeLabelKey))
> throw new IllegalStateException(String.format("The edgeLabelKey value
> of[%s] conflicts with the name of an existing property key to be included in
> the GraphML", this.edgeLabelKey));
> if (identifiedEdgeKeyTypes.containsKey(this.edgeLabelKey))
> throw new IllegalStateException(String.format("The vertexLabelKey value
> of[%s] conflicts with the name of an existing property key to be included in
> the GraphML", this.vertexLabelKey));
> {code}
> The check is identical, but the exception is different?
> This smells like a copy-paste errors and the second check should be more
> like:
> {code:java}
> if (identifiedVertexKeyTypes.containsKey(this.vertexLabelKey))
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
