[
https://issues.apache.org/jira/browse/TINKERPOP-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356661#comment-17356661
]
ASF GitHub Bot commented on TINKERPOP-2507:
-------------------------------------------
spmallette opened a new pull request #1426:
URL: https://github.com/apache/tinkerpop/pull/1426
https://issues.apache.org/jira/browse/TINKERPOP-2507
Upgrade docs in this commit explain this change fairly well. There doesn't
seem to be a need to be so prescriptive about the types that can be filtered on
and it should be up to each graph to decide how they handle such input. Removed
the general exception, tests and updated the behavior of graphs to support the
change.
Decided to put this on 3.6.0 rather than bring what amounts to a behavior
change in the middle of 3.4.x/3.5.x.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove requirement that Graph implementations must filter on homogeneous
> identifiers
> ------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2507
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2507
> Project: TinkerPop
> Issue Type: Bug
> Components: structure
> Affects Versions: 3.4.9
> Reporter: Christopher Smith
> Assignee: Stephen Mallette
> Priority: Major
> Labels: breaking
>
> In {{TinkerGraph#validateHomogenousIds(List)}}, TinkerGraph _explicitly_
> checks for identical ID types among all IDs passed in and provides a
> misleading error message if they mismatch. In fact, this is a semantic error;
> TinkerGraph quite happily supports heterogeneous element ID types.
> In my application, vertex IDs are generally explicitly assigned using
> UUID-as-string values, and so the IDs are primarily of type {{String}}.
> However, my test infrastructure has a few bookkeeping nodes that I'm not
> manually writing IDs to, and TinkerGraph assigns them {{Long}} IDs. These
> mixed IDs work _just fine_, but when I try to pass an {{Object...}} to {{V}},
> TinkerGraph throws.
> Mixing ID types is perfectly legal (if not, in most cases, practically
> advisable), and TinkerGraph should not throw when presented with a mixed
> array of valid IDs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
