[ 
https://issues.apache.org/jira/browse/TINKERPOP-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416473#comment-17416473
 ] 

Florian Hockmann commented on TINKERPOP-1853:
---------------------------------------------

I still think that this would improve the usability of Gremlin.NET. I guess I 
never implemented this because I didn't want to mess more with the old code 
generation logic we had that was already quite complicated. But given that we 
now don't generate the code any more, I want to look into how much work it 
would be to address this manually. But if I come to the conclusion that it's 
too much work for now, then I'll close the issue as it's already nearly 4 years 
old and we don't have to keep it forever without actually implementing anything.

> Use generic version of ITraversal for arguments in Traversal API
> ----------------------------------------------------------------
>
>                 Key: TINKERPOP-1853
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1853
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.3.0, 3.2.6
>            Reporter: Florian Hockmann
>            Priority: Minor
>
> Currently, we use {{ITraversal}} as the type for arguments in the traversal 
> API of Gremlin.Net when a traversal is expected:
> {code}
> public GraphTraversal< S , E2 > Choose<E2> (ITraversal traversalPredicate, 
> ITraversal trueChoice)
> {code}
> The Java equivalent is more useful as it only allows {{Traversal<?, E2>}} for 
> the second argument:
> {code}
> public default <E2> GraphTraversal<S, E2> choose(final Traversal<?, ?> 
> traversalPredicate, final Traversal<?, E2> trueChoice)
> {code}
> We should also use the generic type {{ITraversal<object, E2>}} in Gremlin.Net 
> in those cases. Then it wouldn't be necessary to specify the type for the 
> arguments and the step as it can be interfered from the type of the arguments.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to